feat(ETH): add eth access list (experimental) #2170
Conversation
…etamask, add conf to use access list, edit lists to remove contract address item (no gas reducing)
* dev: feat(nft-swap): add standalone maker contract and proxy support (#2100) feat(ETH): add `gas_limit` coins param to override default values (#2137) feat(tendermint): implement better sequence resolving logic (#2164) ci(artifact): add target for macos on apple silicon (#2163) fix(helpers): extend http to ws address conversion (#2166) fix(makerbot): add "testcoin" to provider options (#2161) fix(hd_wallet): make extended pubkey of hd wallet generic (#2159) fix(docker-tests): implement containers runtime directories (#2162) feat(tendermint): improve the `max` handling for tendermint withdraw (#2155) revert #2158 (comment) (#2160) ci(artifacts): upload build artifacts with in-tree script (#2158) test(tendermint): migrate to local/offline containerized testnets (#2128) use easingthemes/[email protected] for all builds except windows (#2157) chore(bin): rename mm2 binaries to kdf (#2126)
* dev: chore(mm2_main): replace lib.rs by mm2.rs as the root lib (#2178) chore(release): bump mm2 version to 2.2.0-beta (#2188) ci(docker-tests): ignore tendermint IBC tests for now (#2185) feat(nft-swap): complete refund methods (#2129) chore(release): add changelog entries for v2.1.0-beta (#2165) fix(zcoin): don't force low r signing to generate htlc pubkey for zcoin (#2184) chore(rust-analyzer): add rust-analyzer into the workspace toolchain (#2179) chore: migrate .cargo/config to .cargo/config.toml to avoid deprecation warning (#2177) fix(swaps): ensure taker payment spend confirmations (#2176)
…ion by remote version
…d swap msg enum was not compatible with old nodes)
…d "swapext" topic to provide versioning to negotiation
|
This PR becomes important because evm tx type activation by version is added here - allows to do evm swaps with old nodes. |
|
I tried testing this for KomodoPlatform/komodo-docs-mdx#293 but I end up with from request Is something needed in the coins file, or specific params needed during the coin activation? Which coins are (or will be) supported? I've attempted with both |
Gas fee estimator is supported for ETH-like coins with EIP-1559 implemented. (btw proposals to improve this or make similar to other configs appreciated) |
* dev: chore(RPCs): rename `get_peers_info` RPC to `get_directly_connected_peers` (#2195) chore(WASM-builds): remove `wasm-opt` overriding (#2200) fix(coins): add p2p feature to mm2_net dependency (#2210) chore(test): turn on debug assertion (#2204) feat(sia): extract sia lib to external repo (#2167) feat(eth-swap): eth tpu v2 methods, eth docker test enhancements (#2169) fix(cors): allow OPTIONS request to KDF server (#2191) docs(README): update commit badges to use dev branch (#2193) use default value for `komodo_proxy` (#2192) feat(cosmos): komodo-defi-proxy support (#2173)
dimxy
added
under review
and removed
in progress
* dev: fix(orders): fix cancel order race condition using time-based cache (#2232) fix(legacy-swap): taker failed spend maker payment marked as failed (#2199) chore(adex-cli): deprecate adex-cli (#2234) feat(new-RPC): connection healthcheck implementation for peers (#2194) fix(proxy-signature): add message lifetime overflows (#2233) feat(CI): handle remote files in a safer way (#2217) chore(doc): update issue address in README (#2227) fix(merge): remove duplicated db_root function (#2229) feat(wallets): add `get_wallet_names` rpc (#2202) chore(tests): don't use `.wait()` and use `block_on` instead (#2220) fix(native-rpc): remove escaped response body (#2219) fix(clippy): fix coins mod clippy warnings in wasm (#2224) feat(core): handling CTRL-C signal with graceful shutdown (#2213) docs(README): fix typos (#2212) remove the non-sense arguments (#2216) fix(db): stop creating the all-zeroes dir on KDF start (#2218)
This PR initially was optional, for studying eth access lists in swaps. |
* dev: fix(nft): add token_id field to the tx history primary key, fix balance (#2209) feat(cosmos): support IBC types in tx history implementation (#2245) fix(hd-wallet): use `CoinBalanceMap` for UTXO and QTUM (#2259) fix(tests): add more sepolia endpoints in tests (#2262) fix(legacy-swap): check for confirmations on recover taker (#2242) fix(legacy-swap): remove the need for takers to confirm their payment (#2249) refactor(P2P): types and modules (#2256) fix(evm): correctly display eth addr in iguana v2 activation result (#2254) feat(utxo): prioritize electrum connections (#1966) refactor(SwapOps): make all methods async (#2251) refactor(SwapOps): make `send_maker_payment` async (#2250) remove old p2p implementation (#2248)
This is an experimental PR to evaluate whether we can use EIP-2930 access lists.
EVM access lists (added to a transaction calling a contract) may reduce gas consumption when a contract is called. Access list specified addresses and EVM slots which this contract is used and EVM preloads them in memory. EVM operations with such preloaded objects are charged with less gas.
This PR allows to use access lists to swap transactions. The access lists are created with eth_createAccessList rpc with some customisation (namely, removing an access list item pointing to the etomic contract itself which does not reduce gas). Tests show that such customised lists provide saving of 200 to 400 gas units for a call.
To use access lists in swaps a bool "use_access_list" param is added to coins.
I added printing of tx gasUsed in one docker eth test where one can see gas with or without access list (by changing "use_access_list" param in eth test coin config).
attn: @cipig
Also added:
'version' to swap negotiation protocol. New features (eip1559 or access list) won't be used in swap txns if other node has older version.
Fixed:
getting
max_eth_tx_typeandgas_fee_estimatorparams from the platform coin ifenable_eth_with_tokensrpc is used to activate coins (previously worked only whenenablerpc). Problems solved: gas fee estimator did not start and eip1559 txns were not created.